Moving to an event bus strategy for commands

Added workflow and fixed bug with command handling

.github/workflows/ci.yml

@@ -1,4 +1,4 @@
-name: CI
+name: CI (template)
 on: workflow_dispatch
 jobs:
   build:

.github/workflows/publish.yml

@@ -4,14 +4,15 @@ jobs:
   build:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v1
-      - uses: actions/setup-node@v1
-        with:
-          node-version: 14
-          registry-url: https://registry.npmjs.org/
-      - run: yarn
-      - run: yarn build
-      # - run: yarn test
-      - run: yarn publish --access public
+      # Pull repo
+      - uses: actions/checkout@v2
+      # Install bun
+      - uses: oven-sh/setup-bun@v2
+      # Run tests
+      # TODO: Add tests
+      # Build
+      - run: bun build
+      # Publish
+      - run: bun publish
         env:
-          NODE_AUTH_TOKEN: ${{secrets.NPM_TOKEN}}
+          NPM_CONFIG_REGISTRY: https://registry.npmjs.org/_authToken=${{ secrets.NPM_TOKEN }}

package.json

@@ -1,7 +1,7 @@
 {
   "name": "unicord",
-  "description": "A simple discord library primarily for TypeScript. REST like and easy to use.",
-  "version": "0.0.3",
+  "description": "A simple discord library primarily for TypeScript. Web server like and easy to use.",
+  "version": "0.0.4",
   "module": "src/index.ts",
   "type": "module",
   "main": "out/index.js",
@@ -17,7 +17,7 @@
     "build:packages": "bun run build:types && bun run build:core -- --packages external",
     "build:nocheck": "bun run build:types:nocheck && bun run build:core",
     
-    "build:core": "bun build src/index.ts --outdir out --drop=console --drop=debugger",
+    "build:core": "bun build src/index.ts --outdir out --drop=debugger",
     "build:types": "tsc --emitDeclarationOnly --project tsconfig.json",
     "build:types:nocheck": "bun run build:types -- --noCheck",
     

src/services/bus.ts

@@ -5,6 +5,7 @@ const EventBus = new EventEmitter() as Emitter;
 
 export type Emitter = EventEmitter & {
     emit: (event_name: string, context: Context | null, ...args: any[]) => boolean
+    on: (event_name: string, listener: Function) => Emitter
 }
 
 export { EventBus };

src/services/connectors/gateway.ts

@@ -205,14 +205,14 @@ export class Gateway {
             // Generate context
             const context = new Context(this.client, this.api, { message });
             // Dispatch event for the command
-            this.bus.emit(`command:${command}`, context, args);
+            this.bus.emit(`${HandlerType.ChatCommands}:${command}`, context, args);
             // // Check if command exists
             // if (this.processor[HandlerType.ChatCommands].has(command)) {
             //     // Execute the handler
             //     this.processor[HandlerType.ChatCommands].execute(command, context, args);
             // } else {
             //     // TODO: Custom unknown command handler
-            //     context.reply(`Unknown command: ${command}`);
+            //     // context.reply(`Unknown command: ${command}`);
             // }
         }
     };

src/services/processor.ts

@@ -24,6 +24,7 @@ export class Processor {
             const handlers = this.handlers[type].get(e) || [];
             handlers.push(handler);
             this.handlers[type].set(e, handlers);
+            this.bus.on(`${type}:${e}`, async (context: Context | null, payload: any) => { this.execute(type, e, context, payload) });
         }
     };
 
@@ -50,9 +51,10 @@ export class Processor {
         }
     };
 
-    public async execute(type: HandlerType.Events, event: string, context: Context | null, payload: EventPayload): Promise<void>
-    public async execute(type: HandlerType.Interactions, event: string, context: Context | null, payload: InteractionData): Promise<void>
-    public async execute(type: Omit<HandlerType, HandlerType.Events | HandlerType.Interactions>, event: string, context: Context, args: any[]): Promise<void>
+    // TODO: Fix overloads
+    // public async execute(type: HandlerType.Events, event: string, context: Context | null, payload: EventPayload): Promise<void>
+    // public async execute(type: HandlerType.Interactions, event: string, context: Context | null, payload: InteractionData): Promise<void>
+    // public async execute(type: Omit<HandlerType, HandlerType.Events | HandlerType.Interactions>, event: string, context: Context, args: any[]): Promise<void>
     public async execute(type: HandlerType, event: string, context: Context | null, argsOrPayload: any[] | EventPayload) {
         const handlers = this.handlers[type].get(event);
 
@@ -64,6 +66,9 @@ export class Processor {
                         throw new Error('Event handlers cannot be a CommandHandler');
                     }
                     // Validate and resolve the args
+                    // TODO: There's no reason this can't use the hydrator system
+                    // Hydrator should have a more genric subcomponent that can be used anywhere and is more dumb.
+                    // Basically a function that accepts id's and returns values.
                     const resolvedArgs = await this.validateAndResolveArgs(argsOrPayload, handler.args);
                     // Execute the handler
                     await Promise.resolve(handler[Trait.execute](context!, resolvedArgs));